Remove some unnecessary symbol interner ops #61813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jun 13, 2019
|
|
||
| fn intern(&mut self, string: &str, primitive_type: PrimTy) { | ||
| self.primitive_types.insert(Symbol::intern(string), primitive_type); | ||
| let mut table = FxHashMap::default(); |
There was a problem hiding this comment.
There's a neat hashmap! { ... } macro in maplit that we could perhaps use to make this less boiler-platey?
| @@ -314,7 +314,7 @@ impl<'a> Resolver<'a> { | |||
| Ident::new(kw::SelfLower, new_span) | |||
| ), | |||
| kind: ast::UseTreeKind::Simple( | |||
| Some(Ident::from_str_and_span("__dummy", new_span).gensym()), | |||
| Some(Ident::new(kw::Underscore, new_span)), | |||
There was a problem hiding this comment.
Hmm, this code is buggy (#61826), but this change shouldn't make it more buggy since the import is ty::Visibility::Invisible.
|
r=me with the nit addressed |
petrochenkov
added
S-waiting-on-author
matthewjasper
force-pushed
the
remove-unnecessary-symbol-ops
branch
from
bc65021 to
5c84cd3
Compare
|
@bors r=petrochenkov |
|
📌 Commit 5c84cd3 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…mbol-ops, r=petrochenkov Remove some unnecessary symbol interner ops * Don't gensym symbols that don't need to worry about colliding with other symbols * Use symbol constants instead of interning string literals in a few places. * Don't generate a module in `__register_diagnostic` r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 14, 2019
…mbol-ops, r=petrochenkov Remove some unnecessary symbol interner ops * Don't gensym symbols that don't need to worry about colliding with other symbols * Use symbol constants instead of interning string literals in a few places. * Don't generate a module in `__register_diagnostic` r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 15, 2019
…mbol-ops, r=petrochenkov Remove some unnecessary symbol interner ops * Don't gensym symbols that don't need to worry about colliding with other symbols * Use symbol constants instead of interning string literals in a few places. * Don't generate a module in `__register_diagnostic` r? @petrochenkov
bors
added a commit
that referenced
this pull request
Jun 15, 2019
Rollup of 6 pull requests Successful merges: - #61785 (note some safety concerns of raw-ptr-to-ref casts) - #61805 (typeck: Fix ICE for blocks in repeat expr count.) - #61813 (Remove some unnecessary symbol interner ops) - #61824 (in which we decline to lint single-use lifetimes in `derive`d impls) - #61844 (Change `...` to `..=` where applicable) - #61854 (Minor cosmetic improvements to accompany PR 61825) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__register_diagnosticr? @petrochenkov